Ad
  • Custom User Avatar

    Everything in C# is associated with classes and objects, the same could not be said for JS (So, the OOP construct in initial solution setup and tests should be removed)

  • Custom User Avatar

    No random tests in C#

  • Custom User Avatar
    • Description should be language-agnostic (Not sure how to do that with the current inconsistent requirements)

    • As a follow-up from issue by bouchert below, the sorting criteria for tie cases need to be mentioned clearly, as in whether the order breaker should be based on alphabetical order of names / their original position in the input / etc...

  • Custom User Avatar
    • In C# we are given a Dictionary, whereas in JS we are given an array of Objects.

    • Also for output, C# expects a Dictionary whereas JS expects an array of Objects again...

  • Default User Avatar

    Either the ordering criteria of the returned data needs to be dropped or this kata needs to be completely reworked. Depending on how the dictionary is constructed, these tests can and will fail. The only reason this code appears to work for some people at all is because of the limited number of ways these few elements tend to change their orders when hashed. The test code only works by coincidence, if it works at all. The .NET documentation is very clear: For purposes of enumeration, each item in the dictionary is treated as a KeyValuePair<TKey, TValue> structure representing a value and its key. The order in which the items are returned is undefined.. When you call ToList on a Dictionary, you are doing exactly that, enumerating into a new list. Any code that relies on the elements of that list being well-sorted is going to have to sort them on its own, and if we are only able to return a Dictionary, we have no control over that. Ask for an array of string,int tuples or something.

  • Custom User Avatar

    JS version: no random tests :(

  • Default User Avatar

    The initial (default) solution should return an array