Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Yeah thanks a lot!
No worries, it's fixed. Please review. Also, I'd like to thank you for all the effort and time you put in to help me correct this one, I really appreciate it. If you don't mind, I have another translation from this kata series which I corrected side-by-side with this one so it should be almost ready to approve as well.
Did the above changes. Would note though that the way you initialized the "gen" variable caused the compiler to make a most vexing parse error, but I found a way to corretly initialize.
Somehow I didn't save the changes... Nevertheless I changed it again, so please review now
First of all, thank you for the detailed review. Second of all, I think I fixed all of the above, if you'd be so kind to check :)
Also, I tried to define the get_random_staff inside of the It() block, but it said it couldn't be defined there (I moved it outside of the It but still inside the Describe). Do you know why that is?
Thanks!
I did what you ask. No need for a reference solution
Also, I increased the number of test to 500, so the probability of getting every length from 1 to 50 is ~99.8% (before it was ~0.02%).
The feedback based on the pointer address has already been added. If the pointer returned points to the wrong address in memory, it will indicate that. I am also considering changing the description as you suggested. Thank you for your input!
fixed
Also, names
should_return_the_correct_properties_for_given_sum
,Should_pass_shuffled_tests
, andShould_pass_random_tests
are not uniformly formatted. All of them either should start with uppercase or lowercase.I also would like to add that creating a new random engine for every test is rudimentary.
Describe
is a struct, so this has to be done instead:no, the only potentially affected person is you, that's all.
Don't use the editor, use rather the fork button, if you see it (just on the left of the edit button).
The edit panel has side effects on contributors, when it comes to progress elligibility (as in: losing it), if they want to complete the kata in multiple languages and/or translate it also with the idea of gaining the progress in that language.
done
Approved.
Approved :)
Loading more items...