Ad
  • Custom User Avatar

    TL;DR, it all depends on who you are writing the code for. Personally, I enjoyed it but wouldn't write it.

    This feels like an age old argument between concise and readable code. To a complete beginner this would not be very useful or accessible. For me, knowing some JS and a week into learning Python, it is not readable but fun and interesting to dissect and understand, and it helps me to learn. Thank you. And I can easily understand that this becomes quite obvious with time.

  • Custom User Avatar

    Already raised as issue

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    in part from "the Zen of Python"

    "Beautiful is better than ugly.
    Explicit is better than implicit.
    Simple is better than complex.
    Complex is better than complicated."

    i would say the Explicit is better than implicit covers what i'm trying to say.

  • Default User Avatar

    How so? What is Python all about if not abusing built-ins?

  • Default User Avatar

    thank you for the feedback! This is my second Kata i have created (we just won't talk about my first attempt). When you say (in part) "you expect a string returned rather than an error raised (that's a choice design, but generally, when something is wrong, one goes for raising an error" what exactly do you mean? My understanding is to provide the correct answer in the test, and anything other than that would be an error. Are you saying i should provide better feedback in the test?

    I'll look for a more original kata for my next one. thanks again for your feedback, i'll need more to improve :)

  • Custom User Avatar

    Hi,

    • "messy", I guess because of the type conversions, and because you expect a string returned rather than an error raised (that's a choice design, but generally, when something is wrong, one goes for raising an error)
    • "annoying", because of the task itself in addition to the fact that it has already been done a lot of times before.

    If you're interested in kata creation, you should take a close look at these documents (if you did already, that's the "novelty" part that you may have forgotten):

    cheers

  • Custom User Avatar

    There are lots of hour/clock katas already, nothing novel here.

  • Default User Avatar

    in order to pass the random tests in Pythong, i had to add error handling. apparently some of the random tests use lists instead of dictionaries.

  • Default User Avatar

    could you please be more specific?

  • Custom User Avatar

    messy and annoying

  • Default User Avatar

    if you’re going to say "Any input that is NOT a letter should be treated as if it is not there." but you really mean "a subset of all characters that aren't letters should be ignored" please tell us what exactly that subset is.

    I have tried and tried to do this kata, but its way to tricky to account for every situation. for example, I left out everything that isn't a letter only to find out that - is excluded from that statement. really? - is now a letter? I continue and found that the same is true for #

    I refuse to do a Kata where the only answer is to brute force the hole ascii space and test, you are no longer challenging my programing skills but making me guess on the rules of the game. Please be more specific than "Any input that is NOT a letter should be treated as if it is not there."

  • Default User Avatar

    far too compact and against what python is all about

  • Default User Avatar

    Thanks for you guidence and assistance.

  • Custom User Avatar
    • all the available documentation (some parts are out of date, tho...)
    • random tests: pick any (recent) kata you solved, go to your solution, click on the "fork" button under it, then look at/play with the test suite to see how it's done.

    Just an advise: don't try to publish a fresh version of this one: we already have really way too much katas about primes... ;/

  • Loading more items...