Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Random tests go up to
999
, but description promises us10_000
( usemapSize (* 100) $ property $ \ (Positive n) -> do
to get that and automatic shrinking ).A white kata should show inputs on test failure ( use
Test.HUnit.assertEqual
for that ).Thank you for your work, but my knowledge about Haskell is so poor, I don't have confident to approve it...
Approved.
I think you forked your original translation, and updated the description. You could have just forked the kata, and you would have had the current description automatically.
This comment is hidden because it contains spoiler information about the solution
Deprecated ( I guess this was automatic on approval of the other one )
Approved
It would be acceptable if sorting remains unspecified; the description gives only sorted examples but at least there is an example test with an unsorted list.
The description explicitly specifies sets though, and those cannot contain duplicates. This must be addressed, one way or the other.
Description never specified the input is sorted, and it isn't in Python either.
Tests definitely should not generate duplicate entries though, Python explicitly generates sets (and then splats those sets into varargs which is a design choice of all time).
approved by someone.
I'd rather fit the tests to the description than the description to the tests.
approved
Input is not a set but a list. That list is not necessarily sorted and may contain duplicates.
This should very much be specified in the description.
Thanks. Approved.
approved
I believe we should return
Nothing
in Haskell instead of-1
. In fact, in Python it should also be better to returnNone
.Loading more items...